Skip to content

ARROW-1264: [Python] Raise exception in Python instead of aborting if cannot connect to Plasma store#912

Closed
wesm wants to merge 2 commits into
apache:masterfrom
wesm:ARROW-1264
Closed

ARROW-1264: [Python] Raise exception in Python instead of aborting if cannot connect to Plasma store#912
wesm wants to merge 2 commits into
apache:masterfrom
wesm:ARROW-1264

Conversation

@wesm

@wesm wesm commented Jul 29, 2017

Copy link
Copy Markdown
Member

@wesm
Raise exception in Python instead of aborting if cannot connect to Pl…
1d9de77 
…asma store

Change-Id: If1d71473a343638c10ed6ec9e4197bbb69d11a94
@wesm

wesm commented Jul 29, 2017

Copy link
Copy Markdown
Member Author

Not sure why the manylinux1 build failed, giving it a kick

@pcmoritz

pcmoritz commented Jul 29, 2017

Copy link
Copy Markdown
Contributor

Hm, failed again :(

I'm happy to see if I can figure out what's going on here.

@wesm

wesm commented Jul 29, 2017

Copy link
Copy Markdown
Member Author

Sure, that would be helpful! There's so little changed here (outside code formatting) that I'm not sure what could be wrong

@wesm

wesm commented Jul 29, 2017

Copy link
Copy Markdown
Member Author

I'm taking a look also...

@pcmoritz

pcmoritz commented Jul 29, 2017

Copy link
Copy Markdown
Contributor

https://travis-ci.org/pcmoritz/arrow/jobs/258919543

@wesm

wesm commented Jul 29, 2017

Copy link
Copy Markdown
Member Author

Here's the backtrace:

#0  0x00007fffeea5f1d9 in std::uncaught_exception() () from /usr/lib64/libstdc++.so.6
#1  0x00007fffef350fd2 in std::basic_ostream<char, std::char_traits<char> >& std::__ostream_insert<char, std::char_traits<char> >(std::basic_ostream<char, std::char_traits<char> >&, char const*, long) ()
   from /venv-test-2.7/lib/python2.7/site-packages/pyarrow/libarrow_python.so.0
#2  0x00007fffeecbe397 in plasma::ConnectIpcSocketRetry(std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, int, long, int*) () from /venv-test-2.7/lib/python2.7/site-packages/pyarrow/libplasma.so.0
#3  0x00007fffeecb798a in plasma::PlasmaClient::Connect(std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, int, int) ()
   from /venv-test-2.7/lib/python2.7/site-packages/pyarrow/libplasma.so.0
#4  0x00007fffe80f136f in __pyx_pw_7pyarrow_6plasma_3connect(_object*, _object*, _object*) ()
   from /venv-test-2.7/lib/python2.7/site-packages/pyarrow/plasma.so

digging into this

@wesm

wesm commented Jul 29, 2017

Copy link
Copy Markdown
Member Author

It seems there is some kind of permissions error when libplasma tries to write to stderr inside the Docker container. Trying to figure out how to fix it

@pcmoritz

pcmoritz commented Jul 29, 2017

Copy link
Copy Markdown
Contributor

Could it have anything to do with https://docs.pytest.org/en/latest/capture.html?

@wesm

wesm commented Jul 29, 2017

Copy link
Copy Markdown
Member Author

I don't think so. I'm disabling the Plasma unit tests in the Docker build, we should add a follow up JIRA to investigate

@wesm
Add flags to disable certain classes of unit tests
bd134d7 
Change-Id: Ib00b879d3abf0e356d502b8c374324be684670da
@pcmoritz

pcmoritz commented Jul 29, 2017

Copy link
Copy Markdown
Contributor

SGTM: https://issues.apache.org/jira/browse/ARROW-1295

@pcmoritz

pcmoritz commented Jul 29, 2017

Copy link
Copy Markdown
Contributor

+1 LGTM

@asfgit asfgit closed this in 2288bfc Jul 30, 2017
@wesm wesm deleted the ARROW-1264 branch July 30, 2017 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wesm @pcmoritz